fix: massively improve durationRound function, add support for durations #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
durationRoundfunction was quite broken in the sense it did not supporttime.Duration(also stated in the documentation).Furthermore, I improved the algorithm and added more tests.
Nevertheless, I think this function is actually misleading - as it is more a
floorthan around.Changing that would be to invasive I guess, I therefore pointed it out in the docs.
There is one breaking change contained: so far an
int64passed intodurationRoundwas considered a duration in nanoseconds. I am not sure that really matches the expectation of the user. Especially, as it is not consistent withduration.