Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subject alternative URIs when generating cryptographic certificates. #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orendain
Copy link

Resolves #340.

Note: In its current form, this PR breaks current behavior by requiring a new argument for cryptographic functions. How would Sprig maintainers prefer this be adjusted, if at all?

For convenience and reference, I'll include a snippet of #340 here:


Cryptographic Sprig functions (e.g., genSelfSignedCert, genSelfSignedCertWithKey, etc.) currently support clients passing in optional lists of IPs and alternate DNS names.

I propose that these same cryptographic functions may also support clients passing in subject alternative URIs.

The crypto x509 package's Certificate (which Sprig relies on) supports specifying URI subject alternative names, as written in RFC5280:

The subject alternative name extension allows identities to be bound
to the subject of the certificate. These identities may be included
in addition to or in place of the identity in the subject field of
the certificate. Defined options include an Internet electronic mail
address, a DNS name, an IP address, and a Uniform Resource Identifier
(URI)
.

URIs are essential to the SPIFFE standard, where:

In an X.509 SVID, the corresponding SPIFFE ID is set as a URI type in the Subject Alternative Name extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support subject alternative URIs when generating crytographic certificates.
1 participant