Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change trunc to handle unicode (rune counting) #308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change trunc to handle unicode (rune counting) #308

wants to merge 1 commit into from

Commits on Jun 14, 2021

  1. Change trunc to handle unicode (rune counting) 

    Update the trunc func to count and truncate by rune instead of by
byte. When truncating by byte, if a multi-byte unicode character is
encountered, the character will be split and become invalid. Instead,
trunc now looks at the rune count for truncation and a slice of runes
for performing truncation.

After some searching it looks like len([]rune(s)) is compiler
optimized (https://go-review.googlesource.com/c/go/+/108985), so
conversion of the string into a rune slice is not done until trunc
knows truncation needs to be done.
    @andrewmostello
    andrewmostello committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    df089f9 View commit details
    Browse the repository at this point in the history