Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue where validation of constraint section gave false positives #186

Merged
merged 1 commit into from Aug 15, 2022

Commits on Aug 15, 2022

  1. Fixing issue where validation of constraint setion gave false positives

    Closes Masterminds#185
    
    Validation of strings was producing false positives when there were too
    many sections. A string like 1.2.3.1234 would be found in error but on
    like 1.23.3.1234 or 1.2.34.1234 could pass even though it had too many
    segments. This is because a string like 1.23.3.1234 would be found as
    two different constraints of 1.1 and 3.3.1234.
    
    The fix was to treat validation for the the first and following
    constraints separately. For for the following ones a space or command
    is now required before it to show it's a second or further one.
    
    Signed-off-by: Matt Farina <matt@mattfarina.com>
    mattfarina committed Aug 15, 2022
    Copy the full SHA
    ee95afb View commit details
    Browse the repository at this point in the history