Skip to content

Commit

Permalink
add minor version check
Browse files Browse the repository at this point in the history
  • Loading branch information
arshchimni committed Aug 3, 2022
1 parent 49c09bf commit 966635e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions constraints.go
Expand Up @@ -534,6 +534,10 @@ func constraintCaret(v *Version, c *constraint) (bool, error) {
}
return false, fmt.Errorf("%s does not have same minor version as %s. Expected minor versions to match when constraint major version is 0", v, c.orig)
}
// ^ when the minor is 0 and minor > 0 is >=0.y.z < 0.y+1
if c.con.Minor() == 0 && v.Minor() > 0 {
return false, fmt.Errorf("%s does not have same minor version as %s", v, c.orig)
}

// At this point the major is 0 and the minor is 0 and not dirty. The patch
// is not dirty so we need to check if they are equal. If they are not equal
Expand Down
2 changes: 2 additions & 0 deletions constraints_test.go
Expand Up @@ -362,6 +362,8 @@ func TestConstraintsCheck(t *testing.T) {
{"^1.x", "1.1.1-beta1", false},
{"^1.1.2-alpha", "1.2.1-beta1", true},
{"^1.2.x-alpha", "1.1.1-beta1", false},
{"^0.0.1", "0.0.1", true},
{"^0.0.1", "0.3.1", false},
{"~*", "2.1.1", true},
{"~1", "2.1.1", false},
{"~1", "1.3.5", true},
Expand Down

0 comments on commit 966635e

Please sign in to comment.