fix-browser-build #153
Merged
fix-browser-build #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterKale
force-pushed
the
fix-browser-build
branch
from
b8a3322
to
a79987d
Compare
Why did that one-line change to browser's package.json break CI in a different way??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI started hanging because
typescript@4.4.2dropped and there's an issue with@rollup/plugin-typescriptand this latest version of TypeScript.See rollup/plugins#983
This PR keeps @simplewebauthn/browser on
typescript@~4.3.5for now. I'll keep an eye on that Rollup issue and remove this restriction once@rollup/plugin-typescriptgets updated.