Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove mention to nightly #359

Merged
merged 1 commit into from Dec 13, 2023

Conversation

hackaugusto
Copy link
Contributor

Return position impl was enabled in Rust 1.26 in May 10, 2018 [1].

1- https://blog.rust-lang.org/2018/05/10/Rust-1.26.html#impl-trait

Copy link
Owner

@Marwes Marwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, man that has been there for a while. I guess I forgot since the macro really isn't that useful anymore (outside of combine itself I suppose, since it is nice to name the parser types in case someone needs them).

@hackaugusto
Copy link
Contributor Author

CI is failing for something unrelated. Let me know if I should rebase this.

 error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.52/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

@Marwes
Copy link
Owner

Marwes commented Dec 11, 2023

If you do a cargo update and push the updated lockfile I think it should fix itself (seen it before).

@hackaugusto
Copy link
Contributor Author

If you do a cargo update and push the updated lockfile I think it should fix itself (seen it before).

done :)

@Marwes
Copy link
Owner

Marwes commented Dec 12, 2023

Seems like memchr requires more recent rust versions trying to fix it in #360

Return position impl was enabled in Rust 1.26 in May 10, 2018 [1].

1- https://blog.rust-lang.org/2018/05/10/Rust-1.26.html#impl-trait
@hackaugusto
Copy link
Contributor Author

Seems like memchr requires more recent rust versions trying to fix it in #360

rebased this PR over the new master

@Marwes Marwes merged commit 6cac1bd into Marwes:master Dec 13, 2023
4 checks passed
@hackaugusto hackaugusto deleted the hacka-return-position-impl branch December 13, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants