Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use fixed version of go for linting #109

Merged
merged 1 commit into from Apr 5, 2022

Conversation

jamestelfer
Copy link
Contributor

The v3 action doesn't attempt to set up go, allowing the version already set to be used. This fixes an issue where the linter throws a pile of issues like:

  Error: undeclared name: `FuzzInputSdtringGenerateRandom` (typecheck)
  Error: undeclared name: `AssertEqual` (typecheck)
  Error: undeclared name: `AssertEqualValues` (typecheck)
  Error: undeclared name: `AssertKindOf` (typecheck)
  Error: undeclared name: `AssertTestFails` (typecheck)

An alternative is to set golangci-lint to target 1.18, but this disables a lot of checks.

The v3 action doesn't attempt to set up go, allowing the version already
set to be used.
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #109 (dfcd021) into main (77ba3a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          10       10           
  Lines         658      658           
=======================================
  Hits          581      581           
  Misses         40       40           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ba3a4...dfcd021. Read the comment docs.

@MarvinJWendt
Copy link
Owner

Thanks!

@MarvinJWendt MarvinJWendt merged commit 4609f54 into MarvinJWendt:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants