Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nbconvert update and fixes #6102

Merged

Conversation

david-yz-liu
Copy link
Contributor

@david-yz-liu david-yz-liu commented Jul 12, 2022

Motivation and Context

This fixes the displaying of Jupyter notebook files in the grader interface and file preview. There were two issues I encountered:

  1. Running nbconvert raised this error. Updating nbconvert to 6.5.0 fixed this.
  2. PR Added The Ability to Upload URLs #5822 introduced the frame_src CSP, which began preventing Jupyter notebooks from rendering in iframes. Adding :self to the allowed frame_src list fixed this.

Your Changes

Description: Updated nbconvert dependency to 6.5.0 and added :self to frame_src CSP.

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)
  • Other (please specify): dependency update

Testing

Verify that Jupyter notebooks correctly render in the browser.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

@david-yz-liu david-yz-liu merged commit 8548cdf into MarkUsProject:master Jul 13, 2022
@david-yz-liu david-yz-liu deleted the nbconvert-update-and-fixes branch July 13, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants