eth/catalyst: implement kintsugi spec v1.0.0-alpha.3 #29

MariusVanDerWijden · 2021-11-02T19:58:46Z

No description provided.

protolambda · 2021-11-03T16:50:48Z

eth/catalyst/api.go

-			return err
-		}
-		return api.setHead(params.HeadBlockHash)
+func computePayloadId(headBlockHash common.Hash, params *PayloadAttributesV1) uint64 {


This changed in Kintsugi, to a 32-byte ID (just in case EL hashing is adopted by more CLs), and a byte prefixed to the input to version (to easily avoid collisions if we ever need to change the inputs). (not the case anymore)

eth/catalyst/api_test.go

marioevz · 2021-11-05T23:55:18Z

Added a few of test cases here: https://github.com/marioevz/kintsugi_testing

Couple things I noticed so far:

The "id" field does not have any effect on the processing/rejection of a method.
On 'engine_getPayloadV1', returned 'extraData' field is always "0x", regardless of the value on 'engine_executePayloadV1'.
Executing a payload with timestamp far into the future (e.g. "timestamp": "0x1234567890", https://github.com/marioevz/kintsugi_testing/blob/main/src/tests/farFutureTest01.json), results in valid execution, even when 'engine_forkchoiceUpdatedV1' is called to set the block as head (not entirely sure what the outcome should be).
Re-executing the same payload (https://github.com/marioevz/kintsugi_testing/blob/main/src/tests/reExecBlock.json) and re-executing + forkchoiceUpdate several times (https://github.com/marioevz/kintsugi_testing/blob/main/src/tests/reExecBlockAfterForkChoice.json), results in success every time.
Test case https://github.com/marioevz/kintsugi_testing/blob/main/src/tests/revertMultipleTimes.py attempts to call 'engine_forkchoiceUpdatedV1' 100+ times switching between genesis block and another block, results in RPC no longer responding after ~90th attempt.

To run any test case use:
./src/executor/execute.py <Test name>, e.g. ./src/executor/execute.py revertMultipleTimes

params: update Ropsten CHT too

…3855) The price limit is supposed to exclude transactions with too low fee amount. Before EIP-1559, it was sufficient to check the limit against the gas price of the transaction. After 1559, it is more complicated because the concept of 'transaction gas price' does not really exist. When mining, the price limit is used to exclude transactions below a certain effective fee amount. This change makes it apply the same check earlier, in tx validation. Transactions below the specified fee amount cannot enter the pool. Fixes ethereum#23837

* eth/tracers: restructure tracer package * core/vm/runtime: load js tracers * eth/tracers: mv bigint js code to own file * eth/tracers: add method docs for native tracers * eth/tracers: minor doc fix * core,eth: cancel evm on nativecalltracer stop * core/vm: fix failing test Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>

…eum#23872) Debugging recent geth failures in hive, it took a while to realize that it's because geth doesn't support eth/65 any longer. This PR makes such failures a bit more easy to figure out.

Neigbors -> Neighbors

p2p: fix typo in v4wire.go

…23853) This retroactively implements requirements or EIP-2681 for the account nonce upper limit.

* eth/tracers: add slow path for getting legacy logs * core/rawdb: fix test

This was apparently recently changed by Cloudflare, and began returning an error: 'TTL must be between 60 and 86400 seconds, or 1 for Automatic' Date: 2021-11-10 15:25:20-08:00 Signed-off-by: meows <b5c6@protonmail.com>

* native 4byte tracer * Update eth/tracers/native/4byte.go Co-authored-by: Martin Holst Swende <martin@swende.se> * Update eth/tracers/native/4byte.go Co-authored-by: Martin Holst Swende <martin@swende.se> * goimports * eth/tracers: make 4byte tracer not care about create Co-authored-by: Martin Holst Swende <martin@swende.se>

…thereum#23898) Now that `SimulatedBackend.SuggestGasPrice` inspects member values, a lock needs to be added to prevent a race condition.

* cmd/evm: add gas used accumulator to t8n result * cmd/evm: update t8n tests to include gas used field

…3916)

* core/rawdb: better error message in freezer * Apply suggestions from code review

* cmd, core: add flag --dev.gaslimit to allow configuring initial block gas limit in dev mode * core: use provided gaslimit Co-authored-by: Martin Holst Swende <martin@swende.se>

…tsRoot) (ethereum#23924)

This fixes a bug in TransactionSender where it would return the zero address for transactions where the sender address wasn't cached already. Co-authored-by: Felix Lange <fjl@twurst.com>

marioevz · 2021-11-17T23:34:31Z

A couple of findings in the parameters for engine_executePayloadV1:

extraData too long (33 bytes): returns error code for server error (-32000) instead of invalid params (-32602)
logsBloom too long (257 bytes): returns "method handler crashed" error
logsBloom too short (255 bytes): passes and returns same hash as if full 256 bytes value had been received

marioevz · 2021-11-17T23:42:46Z

Adding here the other finding we discussed over discord:

Two re-org cases for random, both do:

eth_sendRawTransaction -> engine_forkchoiceUpdatedV1 -> engine_getPayloadV1 -> engine_executePayloadV1

One of them then does:
engine_forkchoiceUpdatedV1 with payloadAttributes = null, to reorg back to the previous head -> engine_forkchoiceUpdatedV1 with new payloadAttributes

Result: transaction (from the eth_sendRawTransaction) is included in the payload created

Other one does all in one step:
engine_forkchoiceUpdatedV1 with new payloadAttributes

Result: transaction is not included

evm block-builder (a.k.a b11r) is a utility to help assemble blocks, for use during the test-creation process.

core, eth/downloader: fix resetting below freezer threshold

…at (ethereum#23937) * cmd/evm: add support for signing transactions in the unprotected format * cmd/evm: simplify signing of unprotected txs

core/vm: don't use iota for opcode definitions

…thereum#23612) * core/rawdb: utilize AncientRange when initiating from freezer * core/rawdb: remove debug sanity check

trie: reject deletions when verifying range proofs

) * cmd/evm: rename t8n args to improve clarity when tracing * cmd/evm: add back removed tracing flags and note that they are deprecated * cmd/evm: add warning when using deprecated flag

* clique: fix block number unmarshal * clique: rename

) This PR fixes two problems in devp2p tests (and through them, hive). - Make the output more detailed about what is returned (always print packet kind). - Allow Ping response to unsolicited findnode. Without this PR, nethermind fails a hive protocol test, and I misinterpreted the result (NethermindEth/nethermind#3617). Ergo, the output was not fool-proof.

* core/state/snapshot: remove wiper functionality * core/vm: remove unused 'unofficial' opcodes

* all: mv loggers to eth/tracers * core/vm: minor * eth/tracers: tmp comment out testStoreCapture * eth/tracers: uncomment and fix logger test * eth/tracers: simplify test * core/vm: re-add license * core/vm: minor * rename LogConfig to Config

core/vm: use proper JumpTable type

* all: work for eth1/2 transtition * consensus/beacon, eth: change beacon difficulty to 0 * eth: updates * all: add terminalBlockDifficulty config, fix rebasing issues * eth: implemented merge interop spec * internal/ethapi: update to v1.0.0.alpha.2 This commit updates the code to the new spec, moving payloadId into it's own object. It also fixes an issue with finalizing an empty blockhash. It also properly sets the basefee * all: sync polishes, other fixes + refactors * core, eth: correct semantics for LeavePoW, EnterPoS * core: fixed rebasing artifacts * core: light: performance improvements * core: use keyed field (f) * core: eth: fix compilation issues + tests * eth/catalyst: dbetter error codes * all: move Merger to consensus/, remove reliance on it in bc * all: renamed EnterPoS and LeavePoW to ReachTDD and FinalizePoS * core: make mergelogs a function * core: use InsertChain instead of InsertBlock * les: drop merger from lightchain object * consensus: add merger * core: recoverAncestors in catalyst mode * core: fix nitpick * all: removed merger from beacon, use TTD, nitpicks * consensus: eth: add docstring, removed unnecessary code duplication * consensus/beacon: better comment * all: easy to fix nitpicks by karalabe * consensus/beacon: verify known headers to be sure * core: comments * core: eth: don't drop peers who advertise blocks, nitpicks * core: never add beacon blocks to the future queue * core: fixed nitpicks * consensus/beacon: simplify IsTTDReached check * consensus/beacon: correct IsTTDReached check Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com>

* eth: request ID based message dispatcher * eth: fix dispatcher cancellation, rework fetchers idleness tracker * eth/downloader: drop peers who refuse to serve advertised chains

protolambda reviewed Nov 3, 2021

View reviewed changes

lightclient reviewed Nov 5, 2021

View reviewed changes

eth/catalyst/api_test.go Outdated Show resolved Hide resolved

karalabe and others added 10 commits November 8, 2021 14:12

params: update Ropsten CHT too

c4fff0f

Merge pull request ethereum#23869 from karalabe/cht-1.10.12-ropsten

851256e

params: update Ropsten CHT too

eth/tracers: make native calltracer default (ethereum#23867)

787a3b1

params: release Geth v1.10.12

6c4dc6c

params: begin v1.10.13 release cycle

ad11691

cmd/devp2p/internal/ethtest: clarify protocol version in tests (ether…

0efed7f

…eum#23872) Debugging recent geth failures in hive, it took a while to realize that it's because geth doesn't support eth/65 any longer. This PR makes such failures a bit more easy to figure out.

p2p: fix typo in v4wire.go

fb7da82

Neigbors -> Neighbors

Merge pull request ethereum#23880 from eltociear/patch-3

e185a8c

p2p: fix typo in v4wire.go

MariusVanDerWijden force-pushed the kintsugi-spec branch from 9824025 to 42d5abb Compare November 11, 2021 12:33

gumb0 and others added 2 commits November 11, 2021 15:00

core/vm: implement EIP-2681: Limit account nonce to 2^64-1 (ethereum#…

f32feeb

…23853) This retroactively implements requirements or EIP-2681 for the account nonce upper limit.

core/rawdb: add slow path for getting legacy logs (ethereum#23879)

c57df9c

* eth/tracers: add slow path for getting legacy logs * core/rawdb: fix test

MariusVanDerWijden force-pushed the kintsugi-spec branch from d079b86 to faff572 Compare November 11, 2021 14:34

cmd/devp2p: update TTL max for Cloudflare (ethereum#23885)

5358e49

This was apparently recently changed by Cloudflare, and began returning an error: 'TTL must be between 60 and 86400 seconds, or 1 for Automatic' Date: 2021-11-10 15:25:20-08:00 Signed-off-by: meows <b5c6@protonmail.com>

MariusVanDerWijden force-pushed the kintsugi-spec branch from 3a1a2af to e356707 Compare November 11, 2021 19:03

wardbradt and others added 8 commits November 11, 2021 20:20

accounts/abi/bind/backends: fix race condition in simulated backend (e…

abc74a5

…thereum#23898) Now that `SimulatedBackend.SuggestGasPrice` inspects member values, a lock needs to be added to prevent a race condition.

cmd/evm: add gasUsed to t8n result (ethereum#23919)

b0b708b

* cmd/evm: add gas used accumulator to t8n result * cmd/evm: update t8n tests to include gas used field

eth/tracers: make native 4byte default, remove js version (ethereum#2…

05acc27

…3916)

core/rawdb: better error message in freezer (ethereum#23901)

b7a6409

* core/rawdb: better error message in freezer * Apply suggestions from code review

cmd/geth: add flag --dev.gaslimit for dev mode (ethereum#23686)

33f2813

* cmd, core: add flag --dev.gaslimit to allow configuring initial block gas limit in dev mode * core: use provided gaslimit Co-authored-by: Martin Holst Swende <martin@swende.se>

cmd/evm: rename t8n result to match types.Header (ReceiptRoot->Receip…

fa96718

…tsRoot) (ethereum#23924)

ethclient: fix tx sender cache miss detection (ethereum#23877)

16341e0

This fixes a bug in TransactionSender where it would return the zero address for transactions where the sender address wasn't cached already. Co-authored-by: Felix Lange <fjl@twurst.com>

core/vm: don't use iota for opcode definitions

ab31fbb

chfast and others added 7 commits November 22, 2021 08:49

trie: more tests for stacktrie (ethereum#23936)

5d4bcbc

cmd/evm: add b11r tool (ethereum#23843)

441c7f2

evm block-builder (a.k.a b11r) is a utility to help assemble blocks, for use during the test-creation process.

core, eth/downloader: fix resetting below freezer threshold

d9c13d4

Merge pull request ethereum#23949 from karalabe/fix-repair-heuristic

17f1c2d

core, eth/downloader: fix resetting below freezer threshold

cmd/evm: add support for signing transactions in the unprotected form…

23f69c6

…at (ethereum#23937) * cmd/evm: add support for signing transactions in the unprotected format * cmd/evm: simplify signing of unprotected txs

Merge pull request ethereum#23928 from holiman/no_iota

50e07a1

core/vm: don't use iota for opcode definitions

core/rawdb: use AncientRange when initializing leveldb from freezer (e…

347c37b

…thereum#23612) * core/rawdb: utilize AncientRange when initiating from freezer * core/rawdb: remove debug sanity check

MariusVanDerWijden force-pushed the kintsugi-spec branch 2 times, most recently from f34d58e to c124ae9 Compare November 23, 2021 11:59

jfcg and others added 16 commits November 23, 2021 15:14

p2p/enode: store local port number as uint16 (ethereum#23926)

d15e423

trie: reject deletions when verifying range proofs

743769f

Merge pull request ethereum#23960 from karalabe/verify-range-deletion

7322b25

trie: reject deletions when verifying range proofs

cmd/evm: rename t8n args to improve clarity when tracing (ethereum#23934

0a7672f

) * cmd/evm: rename t8n args to improve clarity when tracing * cmd/evm: add back removed tracing flags and note that they are deprecated * cmd/evm: add warning when using deprecated flag

params: release Geth v1.10.13

7a0c19f

params: begin v1.10.14 release cycle

8151dd6

consensus/clique: fix block number unmarshal (ethereum#23961)

66ee942

* clique: fix block number unmarshal * clique: rename

core/vm: use proper JumpTable type

10b1cd9

core/vm, core/state/snapshot: remove unused code (ethereum#23956)

9055cc1

* core/state/snapshot: remove wiper functionality * core/vm: remove unused 'unofficial' opcodes

Merge pull request ethereum#23967 from ipsilon/evm_jumptable_type

4ebeca1

core/vm: use proper JumpTable type

core/vm: simplify op lookup in contract (ethereum#23974)

519cf98

eth: request id dispatcher and direct req/reply APIs (ethereum#23576)

c10a0a6

* eth: request ID based message dispatcher * eth: fix dispatcher cancellation, rework fetchers idleness tracker * eth/downloader: drop peers who refuse to serve advertised chains

eth/catalyst: implement kintsugi spec v1.0.0-alpha.3

ec98b1d

MariusVanDerWijden force-pushed the kintsugi-spec branch from c34a7c5 to ec98b1d Compare November 26, 2021 18:32

MariusVanDerWijden added 4 commits November 30, 2021 12:23

eth/catalyst: fix nitpicks

9795f76

core/genesis.go: fix override

a5df595

eth/catalyst: fixed nitpicks by holiman

4598b2b

eth/catalyst: happy linter happy life

c659403

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eth/catalyst: implement kintsugi spec v1.0.0-alpha.3 #29

eth/catalyst: implement kintsugi spec v1.0.0-alpha.3 #29

MariusVanDerWijden commented Nov 2, 2021

protolambda Nov 3, 2021 •

edited

marioevz commented Nov 5, 2021

marioevz commented Nov 17, 2021

marioevz commented Nov 17, 2021

eth/catalyst: implement kintsugi spec v1.0.0-alpha.3 #29

Are you sure you want to change the base?

eth/catalyst: implement kintsugi spec v1.0.0-alpha.3 #29

Conversation

MariusVanDerWijden commented Nov 2, 2021

protolambda Nov 3, 2021 • edited

Choose a reason for hiding this comment

marioevz commented Nov 5, 2021

marioevz commented Nov 17, 2021

marioevz commented Nov 17, 2021

protolambda Nov 3, 2021 •

edited