forked from markdown-it/markdown-it
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from markdown-it:master #10
Open
pull
wants to merge
69
commits into
MarcelRaschke:master
Choose a base branch
from
markdown-it:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this reflects following commit, no changes are necessary: commonmark/cmark@eb54ef4
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
In this change set I am changing the guidance in the README and in comments to put the class on the correct tag: `<code>`, not `<pre>`. If you put the `hljs` class on `<pre>`, syntax highlighting does not use the correct padding. You can see from the default CSS stylesheet in the highlight.js repo that the `hljs` tag is expected to be on the `<code>` tag: https://github.com/highlightjs/highlight.js/blob/84719c17a51d7bb045f2df441b9c00f871f7c063/src/styles/default.css#L17-L25 All the official highlight.js examples have the `hljs` class on `<code>`: https://highlightjs.org/static/demo/
* Update entities package + usage * Apply custom digital entity logic before entities decode
* Remove spurious state attribute As far as I can see, this attribute is no longer used? * Update pathological.json * Update test/pathological.json
Spec is not clear on how to handle this. Three variations exist: ``` $ echo '![text <textarea> text](image.png)' | /home/user/commonmark.js/bin/commonmark <p><img src="image.png" alt="text <textarea> text" /></p> $ echo '![text <textarea> text](image.png)' | /home/user/cmark/build/src/cmark <p><img src="image.png" alt="text <textarea> text" /></p> $ echo '![text <textarea> text](image.png)' | /home/user/.local/bin/commonmark <p><img src="image.png" alt="text text" /></p> ``` Prior to this commit: - when HTML tags are enabled, tags were removed (as in Haskell version) - when HTML tags are disabled, tags were escaped (as in C version) After this commit: - tags will be escaped (as in C version) regardless of HTML flag + render hardbreaks as newlines, same as cmark
* docs: replace `.js` with `.mjs` in links to files * docs: replace `.js` with `.mjs` in links to files
The spec update changes these things: * It simplifies the HTML regex so that `<!-- a -- b -->` is an HTML comment. HTML5 reports this as an error, but still parses it. * It changes the set of known HTML block elements to match HTML5, adding `search` and removing `source`. * It adds Unicode Symbols to the set of punctuation characters that are used to evaluate flankingness. This commit also changes the declaration HTML regex to match lowercase, even though that change was technically made in spec version 0.30.
Update to spec 0.31.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )