Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): explicitly serialise File due to upstream issue #553

Merged
merged 2 commits into from Sep 7, 2021

Conversation

Malinskiy
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2021

Codecov Report

Merging #553 (32e213d) into develop (86b63bb) will decrease coverage by 0.05%.
The diff coverage is 58.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #553      +/-   ##
=============================================
- Coverage      66.42%   66.37%   -0.06%     
- Complexity       529      533       +4     
=============================================
  Files            120      121       +1     
  Lines           2362     2373      +11     
  Branches         322      323       +1     
=============================================
+ Hits            1569     1575       +6     
- Misses           617      622       +5     
  Partials         176      176              
Impacted Files Coverage Δ
...tlin/com/malinskiy/marathon/json/FileSerializer.kt 0.00% <0.00%> (ø)
...c/main/kotlin/com/malinskiy/marathon/di/Modules.kt 52.38% <25.00%> (-8.74%) ⬇️
...src/main/kotlin/com/malinskiy/marathon/Marathon.kt 73.91% <100.00%> (+1.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b63bb...32e213d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants