Use fixed max senders/receivers due to 10MB limit for max_response_body_size #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dengjianping djptux@gmail.com
Currently, there's a limit on the
max_response_body_size
, which is 10MB(10485760
bytes).So by calculation, 10MB means
Before serialization, the data in memory is about
3.39
MB.But after serialization, it will become
9.88
MB, almost 10MB.So if any number exceeds
1024 * 16
, the server will return an error like thisTake a look at this PR: paritytech/jsonrpsee#711
and https://github.com/paritytech/jsonrpsee/blob/v0.15.1/core/src/lib.rs#L81
So we have to use fixed values for
(max_senders, max_receivers)
.jsonrpsee
is using serde for serialization/deserialization, seems there's no way to change to another crate likecodec
for more compacted data.