Match messages with multispans and multiple messages on a line #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example '9' in `//~ ERROR*9 foo`
Duplicate actual errors are allowed by default. Errors with multispans are considered as duplicated for each sub-span. This is a [breaking-change] to compiletest's behavior.
|
I'm not sure about making the change in behavior for multiple messages. Should the following expected error match two actual errors? // Should get errors for both 'Some' and 'None'
use std::option::Option::{Some, None}; //~ ERROR unused import |
dtolnay
reviewed
Oct 29, 2018
There was a problem hiding this comment.
This should be added upstream in rust-lang/rust first (https://github.com/rust-lang/rust/tree/master/src/tools/compiletest). Then it will be picked up by this crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Example of an expected error that matches 2 actual errors