Use stable libtest

[gnzlbg]

WIP: this uses my branch of stable libtest, that will be merged as part of rust-lang/libtest#11 . Once that is merged I'll update this PR to use libtest 0.0.2, but I wanted to make sure that CI here works fine first.

[mati865]

error: pretty-printing failed in round 0 revision None
status: exit code: 1
command: "rustc" "-" "-Z" "unpretty=expanded" "--target" "x86_64-unknown-linux-gnu" "-L" "/tmp/compiletestGdXCMX/macro.stage-id.pretty.aux" "-L" "target/debug" "-L" "target/debug/deps"
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
error: the option `Z` is only accepted on the nightly compiler
------------------------------------------
thread '[pretty] pretty/macro.rs' panicked at 'explicit panic', /home/travis/build/laumann/compiletest-rs/src/runtest.rs:2632:9

[Munksgaard]

Our session-types library also broke due to the recent changes in compiletest. Your changes seem to fix some of the issue, but I'm still getting the following errors when trying to compile with this branch:

error[E0658]: `cfg(target_vendor)` is experimental and subject to change (see issue #29718)                       
    --> /home/munksgaard/.cargo/git/checkouts/libtest-ed9c19a14a678411/584b2b3/src/lib.rs:1052:9                  
     |                                                                                                            
1052 |     all(target_vendor = "fortanix", target_env = "sgx")                                                    
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                         
                                                                                                                  
error[E0658]: `cfg(target_vendor)` is experimental and subject to change (see issue #29718)                       
    --> /home/munksgaard/.cargo/git/checkouts/libtest-ed9c19a14a678411/584b2b3/src/lib.rs:1289:13                 
     |                                                                                                            
1289 |         all(target_vendor = "fortanix", target_env = "sgx")                                                
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^                                

That's on a stable build by the way.

[mati865]

@Munksgaard on which stable version?
cfg_target_vendor was stabilized in 1.33.0.

[Munksgaard]

@mati865, you're right, I was using an old stable version. After updating to 1.33.0 everything is dandy with compiletest_rs = { git = "https://github.com/gnzlbg/compiletest-rs", branch = "stable_libtest" } in my Cargo.toml. Thanks for pointing that out :-)

[laumann]

This removes the tester crate entirely, if I understand correctly?

[laumann]

Please don't do version bumps in this commit, I do that separately.

[laumann]

How about nightly for the feature name?

[laumann]

Why the rename to libtest?

[Manishearth]

Don't want it to try and link with the local test crate that is unstable and broken now.

[RalfJung]

But an as import will never change what gets linked. So why not keep extern crate libtest as test?

[Manishearth]

Is this ready to land? The PR description still says WIP.

[Manishearth]

Oh, the other PR needs to merge

[RalfJung]

Ping, any update on this?

[Manishearth]

We're currently reverting the libtest changes in Rust, but the path forward will likely involve landing this eventually, keeping it open for now.

[RalfJung]

What is the status of this? We just ran into another compiletest feature that hasn't been synced here yet (and it's been in rustc for more than 2 years).

[gnzlbg]

Someone needs to replace compiletest in rust-lang/rust with this crate to avoid the duplication. I don't think anybody is working on that.

[RalfJung]

Interesting, thanks! Some time ago I was told that someone is working on it and it would happen right after the next Rust release. Oh well.