Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cleanup in clean_rmeta() #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aldanor
Copy link

@aldanor aldanor commented Nov 18, 2018

clean_rmeta() now removes more files (for each foo.rmeta found, it also removes all foo.*). Folders are no longer limited to */deps.

@aldanor
Copy link
Author

aldanor commented Nov 18, 2018

To be honest, I'm not 100% comfortable with this in general (which also applies to the current version of .clean_rmeta(), but at least it only looks in */deps folders...), since it will go and start removing things in folders that are potentially outside of the crate's (or workspace's) scope, for each -L entry.

Should this be only limited to the folders appended by .link_deps() perhaps? In which case it could be something like .link_deps_and_clean().

@laumann
Copy link
Collaborator

laumann commented Nov 19, 2018

First of all, thanks for submitting this 👍

We could start by either adding a flag to clean_rmeta() that would enable/disable this new behaviour, or we could put this in a function by itself until we think it's the right way to go.

I'm curious if I could get others who ran into #114 to check this out: @hannobraun @MoSal Would this solve the problems you had?

@aldanor
Copy link
Author

aldanor commented Nov 19, 2018

I think the way the current clean_rmeta() works may actually be wrong since it may leave the cache in a half-broken state (with only .rmeta files gone). This PR pretty just fixes that... so if everyone's happy with the way it works, maybe the easiest way would be to just merge it in. Alternatively - rename the new function to something like clean_artifacts() and then deprecate the old clean_rmeta() eventually.

I've noticed one more thing which I must've misread in the original code: the target_rustcflags is just a string of of all flags, right? (i.e., could be link flags or anything else)

So, when you split them by whitespace, would-Lfoo/deps -L bar -L native=baz --sysroot /opt/rust result in ['-Lfoo/deps', '-L', 'bar', '-L', 'native=baz', '--sysroot', '/opt/rust/'] then? It would miss 2 out of 3 library folders and then it will go hunting for rmeta files where it shouldn't. Should it rather yield ['foo/deps', 'bar', 'baz']? In which case we'd have to parse the flags string properly. (this is also somewhat of a problem in the current impl as well)

@hannobraun
Copy link

Unfortunately I can still reproduce my original issue using the branch from this pull request.

@aldanor
Copy link
Author

aldanor commented Nov 19, 2018

@hannobraun Thanks. Did you actually call .clean_rmeta()? (just making sure)

Could you please try posting before/after diffs of the target/ folder?

Something like

$ cargo clean
$ cargo test --features compiletest
$ find target -type f > 1.txt
$ cargo test
$ find target -type f > 2.txt
$ diff 1.txt 2.txt

@hannobraun
Copy link

@aldanor

@hannobraun Thanks. Did you actually call .clean_rmeta()? (just making sure)

Yes, I just confirmed. (and good call making sure, because I forgot to confirm before)

Could you please try posting before/after diffs of the target/ folder?

Something like

$ cargo clean
$ cargo test --features compiletest
$ find target -type f > 1.txt
$ cargo test
$ find target -type f > 2.txt
$ diff 1.txt 2.txt

This is what I'm getting:

--- 1.txt	2018-11-19 19:07:26.668824268 +0100
+++ 2.txt	2018-11-19 19:07:55.845919010 +0100
@@ -95,6 +95,18 @@
 target/debug/deps/liblpc82x_hal-8d490e0489b4f078.rlib
 target/debug/deps/compiletest-a53ab5e07cdcd528.d
 target/debug/deps/compiletest-a53ab5e07cdcd528
+target/debug/deps/lpc82x_hal-aa09a6587af01dff.d
+target/debug/deps/syn-0b564df66a95fef7.d
+target/debug/deps/libsyn-0b564df66a95fef7.rlib
+target/debug/deps/cortex_m_rt_macros-4a489c6f9cbdc929.d
+target/debug/deps/libcortex_m_rt_macros-4a489c6f9cbdc929.so
+target/debug/deps/cortex_m_rt-871bcad94308b793.d
+target/debug/deps/libcortex_m_rt-871bcad94308b793.rlib
+target/debug/deps/lpc82x_hal-9a38bd704b289035.d
+target/debug/deps/liblpc82x_hal-aa09a6587af01dff.rlib
+target/debug/deps/compiletest-a3f84893a0fa500b.d
+target/debug/deps/compiletest-a3f84893a0fa500b
+target/debug/deps/lpc82x_hal-9a38bd704b289035
 target/debug/incremental/lpc82x_hal-1a342moivvr3h/s-f6tnzwzs6v-13d8w3p.lock
 target/debug/incremental/lpc82x_hal-1a342moivvr3h/s-f6tnzwzs6v-13d8w3p-rw1dbujgz3yv/query-cache.bin
 target/debug/incremental/lpc82x_hal-1a342moivvr3h/s-f6tnzwzs6v-13d8w3p-rw1dbujgz3yv/dep-graph.bin
@@ -265,6 +277,170 @@
 target/debug/incremental/compiletest-2um8k6tzinpp1/s-f6to025vqj-p5tbb8-3j1hr4saz06z5/56bfaqu0flin4c23.o
 target/debug/incremental/compiletest-2um8k6tzinpp1/s-f6to025vqj-p5tbb8-3j1hr4saz06z5/m11gukq92s432aq.o
 target/debug/incremental/compiletest-2um8k6tzinpp1/s-f6to025vqj-p5tbb8-3j1hr4saz06z5/work-products.bin
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp.lock
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/query-cache.bin
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/dep-graph.bin
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/10vgcwjvvjbiqmiz.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/10vgcwjvvjbiqmiz.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/12nngwfq5g3hcc29.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/12nngwfq5g3hcc29.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/145k8znlt3m7vbv.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/145k8znlt3m7vbv.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1cc54jrijadpq5ff.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1cc54jrijadpq5ff.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1pkl0875dyiyt49n.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1pkl0875dyiyt49n.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1qgfqjug0ijv8eee.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1qgfqjug0ijv8eee.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1qgzdj9jka22b86c.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1qgzdj9jka22b86c.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1tp2myh2b3j94w8d.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1tp2myh2b3j94w8d.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1u4cr0v5naaevx20.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1u4cr0v5naaevx20.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1ufbuwoemr4lqvzd.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1ufbuwoemr4lqvzd.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1y0vkjl8jqzuquh6.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1y0vkjl8jqzuquh6.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1zgjwze8emz7mwsl.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/1zgjwze8emz7mwsl.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/26j7m1lsnj0yvff8.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/26j7m1lsnj0yvff8.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/27gsvxvqfejr3xxx.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/27gsvxvqfejr3xxx.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/28p2eropswdxm10m.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/28p2eropswdxm10m.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/28uxxzgydn7bb1n3.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/28uxxzgydn7bb1n3.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2bdevokzpc2izn4q.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2bdevokzpc2izn4q.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2cruo44xw8w78ijn.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2cruo44xw8w78ijn.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2dx72vkxu4k0vix3.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2dx72vkxu4k0vix3.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2ffj4mtfrc4lpz3f.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2ffj4mtfrc4lpz3f.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2itdjtzuicilrqr9.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2itdjtzuicilrqr9.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2iw6ktyijsrxyw56.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2iw6ktyijsrxyw56.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2m8li7dbd490y7hg.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2m8li7dbd490y7hg.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2pj969q4cl68odc3.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2pj969q4cl68odc3.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2qrdnk8nppomjr9t.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2qrdnk8nppomjr9t.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2ugy6hf53yvj2tvd.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2ugy6hf53yvj2tvd.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2utsupg45gl263h1.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2utsupg45gl263h1.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2vrtutek3n1yrxde.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2vrtutek3n1yrxde.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2wl13seyr2ja1waa.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/2wl13seyr2ja1waa.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/35f163ilyt3wjrc8.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/35f163ilyt3wjrc8.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3jn4uu826lyd8ldw.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3jn4uu826lyd8ldw.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3lljdu1z4dfuxd83.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3lljdu1z4dfuxd83.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3ousjk567tnt52na.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3ousjk567tnt52na.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3pka3ldgtzqtubg7.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3pka3ldgtzqtubg7.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3vtxasld184bc42a.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3vtxasld184bc42a.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3w4gi6opzuqui7sy.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3w4gi6opzuqui7sy.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3xr828qul0eaxfbf.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/3xr828qul0eaxfbf.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/40i5shxtc0k6sgbw.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/40i5shxtc0k6sgbw.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/42l5fengvoqu1b6.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/42l5fengvoqu1b6.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/43b6dztmqoxo6ijb.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/43b6dztmqoxo6ijb.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/46l2v9ori99stlsa.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/46l2v9ori99stlsa.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/47eucmkc1jccsi5g.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/47eucmkc1jccsi5g.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/47il3ce9izzgdmyn.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/47il3ce9izzgdmyn.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/491r70octybo1qfr.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/491r70octybo1qfr.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/495s6luexbqsdphs.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/495s6luexbqsdphs.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4ajzb332zzr7kuy8.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4ajzb332zzr7kuy8.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4bt79axh4yntbn71.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4bt79axh4yntbn71.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4iwkjk655szi7ont.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4iwkjk655szi7ont.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4j9onuadtrj3mbd1.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4j9onuadtrj3mbd1.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4jss2hjrww0scrzq.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4jss2hjrww0scrzq.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4oag5kp1m5egit62.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4oag5kp1m5egit62.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4s0kawrl3bk6x7u0.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/4s0kawrl3bk6x7u0.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/51gtyxdjmq16p235.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/51gtyxdjmq16p235.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5avl4d63kpmnuyye.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5avl4d63kpmnuyye.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5cfzif0qpg0jil1x.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5cfzif0qpg0jil1x.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5e7egmoo8t38vqds.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5e7egmoo8t38vqds.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5f4o9eiesrx7lkou.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5f4o9eiesrx7lkou.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5xfvc8jlylh0jwr.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/5xfvc8jlylh0jwr.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/7cdc5soj8zqfeoy.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/7cdc5soj8zqfeoy.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/a9458t5lmkgu9uv.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/a9458t5lmkgu9uv.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/bfsor4rrh6otvfw.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/bfsor4rrh6otvfw.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/bv6sp916ysoct73.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/bv6sp916ysoct73.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/ctsxctv2me6drpe.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/ctsxctv2me6drpe.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/cuxzddmdcsmxfri.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/cuxzddmdcsmxfri.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/hlqe1o1tvmeatbc.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/hlqe1o1tvmeatbc.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/kgjokasp2ipsy0r.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/kgjokasp2ipsy0r.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/ku4nb2gghtamxjr.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/ku4nb2gghtamxjr.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/pxyhk78n8z0ecgm.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/pxyhk78n8z0ecgm.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/qgy3ye52vuadqqk.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/qgy3ye52vuadqqk.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/s1mrfks4999nq7q.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/s1mrfks4999nq7q.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/sl1vya2tubprynl.o
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/sl1vya2tubprynl.bc.z
+target/debug/incremental/lpc82x_hal-1wocbi0z6y388/s-f6to0olqsp-1bgtsgp-a2hif6eiru5n/work-products.bin
+target/debug/incremental/lpc82x_hal-143lqxdopmtdu/s-f6to0twhyx-mvejz2.lock
+target/debug/incremental/lpc82x_hal-143lqxdopmtdu/s-f6to0twhyx-mvejz2-1jdab9rriei7y/query-cache.bin
+target/debug/incremental/lpc82x_hal-143lqxdopmtdu/s-f6to0twhyx-mvejz2-1jdab9rriei7y/dep-graph.bin
+target/debug/incremental/lpc82x_hal-143lqxdopmtdu/s-f6to0twhyx-mvejz2-1jdab9rriei7y/22j4erfvxeo0525j.o
+target/debug/incremental/lpc82x_hal-143lqxdopmtdu/s-f6to0twhyx-mvejz2-1jdab9rriei7y/336mkbqymev612v8.o
+target/debug/incremental/lpc82x_hal-143lqxdopmtdu/s-f6to0twhyx-mvejz2-1jdab9rriei7y/3qjxtejv78fpavui.o
+target/debug/incremental/lpc82x_hal-143lqxdopmtdu/s-f6to0twhyx-mvejz2-1jdab9rriei7y/5b0y2beo3o632bqq.o
+target/debug/incremental/lpc82x_hal-143lqxdopmtdu/s-f6to0twhyx-mvejz2-1jdab9rriei7y/p8rlvmtigmcoogx.o
+target/debug/incremental/lpc82x_hal-143lqxdopmtdu/s-f6to0twhyx-mvejz2-1jdab9rriei7y/work-products.bin
+target/debug/incremental/compiletest-fkmzqmu0cigf/s-f6to0ue3ls-1x41b4i.lock
+target/debug/incremental/compiletest-fkmzqmu0cigf/s-f6to0ue3ls-1x41b4i-3bnnb373xzvsd/query-cache.bin
+target/debug/incremental/compiletest-fkmzqmu0cigf/s-f6to0ue3ls-1x41b4i-3bnnb373xzvsd/dep-graph.bin
+target/debug/incremental/compiletest-fkmzqmu0cigf/s-f6to0ue3ls-1x41b4i-3bnnb373xzvsd/2ti63677tnfpeo9c.o
+target/debug/incremental/compiletest-fkmzqmu0cigf/s-f6to0ue3ls-1x41b4i-3bnnb373xzvsd/2yjoc9op2coazm5l.o
+target/debug/incremental/compiletest-fkmzqmu0cigf/s-f6to0ue3ls-1x41b4i-3bnnb373xzvsd/3ww6y6n7jnkpo43o.o
+target/debug/incremental/compiletest-fkmzqmu0cigf/s-f6to0ue3ls-1x41b4i-3bnnb373xzvsd/41lcbfi90frqd2qn.o
+target/debug/incremental/compiletest-fkmzqmu0cigf/s-f6to0ue3ls-1x41b4i-3bnnb373xzvsd/5788bunk4j5ywpvi.o
+target/debug/incremental/compiletest-fkmzqmu0cigf/s-f6to0ue3ls-1x41b4i-3bnnb373xzvsd/work-products.bin
 target/debug/.fingerprint/compiletest_rs-1ae7ecec350b030e/dep-lib-compiletest_rs-1ae7ecec350b030e
 target/debug/.fingerprint/compiletest_rs-1ae7ecec350b030e/lib-compiletest_rs-1ae7ecec350b030e
 target/debug/.fingerprint/compiletest_rs-1ae7ecec350b030e/lib-compiletest_rs-1ae7ecec350b030e.json
@@ -459,6 +635,24 @@
 target/debug/.fingerprint/lpc82x-hal-a53ab5e07cdcd528/dep-test-integration-test-compiletest-a53ab5e07cdcd528
 target/debug/.fingerprint/lpc82x-hal-a53ab5e07cdcd528/test-integration-test-compiletest-a53ab5e07cdcd528
 target/debug/.fingerprint/lpc82x-hal-a53ab5e07cdcd528/test-integration-test-compiletest-a53ab5e07cdcd528.json
+target/debug/.fingerprint/cortex-m-rt-871bcad94308b793/dep-lib-cortex_m_rt-871bcad94308b793
+target/debug/.fingerprint/cortex-m-rt-871bcad94308b793/lib-cortex_m_rt-871bcad94308b793
+target/debug/.fingerprint/cortex-m-rt-871bcad94308b793/lib-cortex_m_rt-871bcad94308b793.json
+target/debug/.fingerprint/cortex-m-rt-macros-4a489c6f9cbdc929/dep-lib-cortex_m_rt_macros-4a489c6f9cbdc929
+target/debug/.fingerprint/cortex-m-rt-macros-4a489c6f9cbdc929/lib-cortex_m_rt_macros-4a489c6f9cbdc929
+target/debug/.fingerprint/cortex-m-rt-macros-4a489c6f9cbdc929/lib-cortex_m_rt_macros-4a489c6f9cbdc929.json
+target/debug/.fingerprint/syn-0b564df66a95fef7/dep-lib-syn-0b564df66a95fef7
+target/debug/.fingerprint/syn-0b564df66a95fef7/lib-syn-0b564df66a95fef7
+target/debug/.fingerprint/syn-0b564df66a95fef7/lib-syn-0b564df66a95fef7.json
+target/debug/.fingerprint/lpc82x-hal-aa09a6587af01dff/dep-lib-lpc82x_hal-aa09a6587af01dff
+target/debug/.fingerprint/lpc82x-hal-aa09a6587af01dff/lib-lpc82x_hal-aa09a6587af01dff
+target/debug/.fingerprint/lpc82x-hal-aa09a6587af01dff/lib-lpc82x_hal-aa09a6587af01dff.json
+target/debug/.fingerprint/lpc82x-hal-a3f84893a0fa500b/dep-test-integration-test-compiletest-a3f84893a0fa500b
+target/debug/.fingerprint/lpc82x-hal-a3f84893a0fa500b/test-integration-test-compiletest-a3f84893a0fa500b
+target/debug/.fingerprint/lpc82x-hal-a3f84893a0fa500b/test-integration-test-compiletest-a3f84893a0fa500b.json
+target/debug/.fingerprint/lpc82x-hal-9a38bd704b289035/dep-test-lib-lpc82x_hal-9a38bd704b289035
+target/debug/.fingerprint/lpc82x-hal-9a38bd704b289035/test-lib-lpc82x_hal-9a38bd704b289035
+target/debug/.fingerprint/lpc82x-hal-9a38bd704b289035/test-lib-lpc82x_hal-9a38bd704b289035.json
 target/debug/build/compiletest_rs-bd6e87288aa91e3b/build_script_build-bd6e87288aa91e3b.d
 target/debug/build/compiletest_rs-bd6e87288aa91e3b/build_script_build-bd6e87288aa91e3b
 target/debug/build/compiletest_rs-bd6e87288aa91e3b/build-script-build
@@ -524,4 +718,8 @@
 target/debug/compiletest-a53ab5e07cdcd528
 target/debug/lpc82x_hal-fd72317ba990419e.d
 target/debug/compiletest-a53ab5e07cdcd528.d
+target/debug/compiletest-a3f84893a0fa500b
+target/debug/lpc82x_hal-9a38bd704b289035
+target/debug/compiletest-a3f84893a0fa500b.d
+target/debug/lpc82x_hal-9a38bd704b289035.d
 target/.rustc_info.json

@aldanor
Copy link
Author

aldanor commented Nov 19, 2018

@hannobraun Thanks, this is helpful. So, I don't see any rmetas like in my case, but rather new rlibs (also, I've tested this on darwin and you're obviously on linux-64).

So basically, noise aside, it boils down to these:

+target/debug/deps/lpc82x_hal-aa09a6587af01dff.d
+target/debug/deps/syn-0b564df66a95fef7.d
+target/debug/deps/libsyn-0b564df66a95fef7.rlib
+target/debug/deps/cortex_m_rt_macros-4a489c6f9cbdc929.d
+target/debug/deps/libcortex_m_rt_macros-4a489c6f9cbdc929.so
+target/debug/deps/cortex_m_rt-871bcad94308b793.d
+target/debug/deps/libcortex_m_rt-871bcad94308b793.rlib
+target/debug/deps/lpc82x_hal-9a38bd704b289035.d
+target/debug/deps/liblpc82x_hal-aa09a6587af01dff.rlib
+target/debug/deps/compiletest-a3f84893a0fa500b.d
+target/debug/deps/compiletest-a3f84893a0fa500b
+target/debug/deps/lpc82x_hal-9a38bd704b289035
+target/debug/compiletest-a3f84893a0fa500b
+target/debug/lpc82x_hal-9a38bd704b289035
+target/debug/compiletest-a3f84893a0fa500b.d
+target/debug/lpc82x_hal-9a38bd704b289035.d

Could you check what's the minimal set of files to kill so that it works (i.e. so you could then run cargo test --features compiletest)?

# option 1
$ rm target/debug/deps/libsyn-0b564df66a95fef7.rlib
$ rm target/debug/deps/libcortex_m_rt-871bcad94308b793.rlib
$ rm target/debug/deps/liblpc82x_hal-aa09a6587af01dff.rlib

# option 2
$ rm target/debug/deps/libsyn-0b564df66a95fef7.rlib
$ rm target/debug/deps/syn-0b564df66a95fef7.d
$ rm target/debug/deps/libcortex_m_rt-871bcad94308b793.rlib
$ rm target/debug/deps/cortex_m_rt-871bcad94308b793.d
$ rm target/debug/deps/liblpc82x_hal-aa09a6587af01dff.rlib
$ rm target/debug/deps/lpc82x_hal-aa09a6587af01dff.d

If option 1 works, should we also kill all rlibs as part of the cleaning process?

@hannobraun
Copy link

@aldanor

Could you check what's the minimal set of files to kill so that it works (i.e. so you could then run cargo test --features compiletest)?

# option 1
$ rm target/debug/deps/libsyn-0b564df66a95fef7.rlib
$ rm target/debug/deps/libcortex_m_rt-871bcad94308b793.rlib
$ rm target/debug/deps/liblpc82x_hal-aa09a6587af01dff.rlib

Option 1 works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants