Use bootsnap 1.8.1 for psych 4 / 3 compatibility #21963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psych unsafe_load was added for psych 4 / 3 compatibility but was only available in 3.3.2 and newer. Prior to this change, bootsnap 1.8.0 would be break on psych 3.3.1 and older. Bootsnap added psych 4 compatibility in 1.8.0 by using unsafe_load but this doesn't work with 3.3.1 or older: Shopify/bootsnap#368 Bootnap 1.8.1 allows older versions of psych to be compatible via: Shopify/bootsnap#369
|
cc @jeffibm @MelsHyrule @GilbertCherrie Can one of you verify this PR? I did a quick run through of the UI but didn't really have data to click around much. My guess is dev mode code reloading is what might be problematic with a bootsnap version change. |
Fryguy
approved these changes
Jun 28, 2022
|
Checked commit jrafanie@5136659 with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
GilbertCherrie
approved these changes
Jun 28, 2022
GilbertCherrie
approved these changes
Jun 28, 2022
|
Merging since we have a review from UI - we can revert if it causes problem, but I'm not expecting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psych unsafe_load was added for psych 4 / 3 compatibility but was only available
in 3.3.2 and newer.
Prior to this change, bootsnap 1.8.0 would be break on psych 3.3.1 and older.
Bootsnap added psych 4 compatibility in 1.8.0 by using unsafe_load but this
doesn't work with 3.3.1 or older:
Shopify/bootsnap#368
Bootnap 1.8.1 allows older versions of psych to be compatible via:
Shopify/bootsnap#369
Discovered this possible problem while debugging ManageIQ/sprint_statistics#70