Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec for Foreman provider creation #11421

Merged

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Sep 21, 2016

Unfortunately, rack-test does not support params on post. (Filed rack/rack-test#150) -- so we need to hardcode '?provider_class=provider'.

@miq-bot add_label api, test
@miq-bot assign @abellotti

@miq-bot
Copy link
Member

miq-bot commented Sep 21, 2016

Checked commit isimluk@dc504d6 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. ⭐

@imtayadeway
Copy link
Contributor

Unfortunately, rack-test does not support params on post. (Filed rack/rack-test#150) -- so we need to hardcode '?provider_class=provider'.

@isimluk are you sure this isn't because run_post isn't sending any params to post: https://github.com/ManageIQ/manageiq/blob/master/spec/support/api_helper.rb#L39 ?

@isimluk
Copy link
Member Author

isimluk commented Sep 22, 2016

@isimluk are you sure this isn't because run_post isn't sending any params to post: https://github.com/ManageIQ/manageiq/blob/master/spec/support/api_helper.rb#L39 ?

Yes. When run_post starts sending it, we will hit aforementioned rack-test issue.

@abellotti abellotti added this to the Sprint 47 Ending Oct 3, 2016 milestone Sep 22, 2016
@abellotti
Copy link
Member

@isimluk Thanks for adding the test. LGTM!

@abellotti abellotti merged commit a100574 into ManageIQ:master Sep 22, 2016
chessbyte pushed a commit that referenced this pull request Sep 29, 2016
…tion

Spec for Foreman provider creation
(cherry picked from commit a100574)
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log
commit 1b4a9a3ef9a0a56c4ad00e1faeaf8524c270fe20
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Thu Sep 22 07:47:09 2016 -0400

    Merge pull request #11421 from isimluk/spec-for-foreman-provider-creation

    Spec for Foreman provider creation
    (cherry picked from commit a1005741ca6cca342cd4a14e28a6f43cf295cadb)

@isimluk isimluk deleted the spec-for-foreman-provider-creation branch May 3, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants