Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Set the version of file-selector to be stricter than in react-dropzone #1146

Merged
merged 1 commit into from Oct 23, 2020

Conversation

skateman
Copy link
Member

The react-dropzone package is breaking the CI/webpack on the ui-classic repo. The issue is probably with the 0.2.x version of the file-selector dependency of this package that came out a few hours ago. A quick band-aid is to fixate the version of this secondary dependency more stricter than react-dropzone.

ERROR in /home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/bundler/gems/manageiq-v2v-0a7e157c539f/node_modules/react-dropzone/dist/es/index.js
Module not found: Error: Can't resolve 'file-selector' in '/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/bundler/gems/manageiq-v2v-0a7e157c539f/node_modules/react-dropzone/dist/es'
 @ /home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/bundler/gems/manageiq-v2v-0a7e157c539f/node_modules/react-dropzone/dist/es/index.js 30:0-42 378:61-70

@miq-bot
Copy link
Member

miq-bot commented Oct 23, 2020

Checked commit skateman@048af00 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@skateman
Copy link
Member Author

FYI @himdel this is just a band-aid to unblock everyone on ui-classic, so I guess it will need a proper fix...

@mzazrivec mzazrivec self-assigned this Oct 23, 2020
@mzazrivec mzazrivec merged commit 6e0df95 into ManageIQ:master Oct 23, 2020
@skateman skateman deleted the file-selector-version branch October 23, 2020 10:06
@himdel
Copy link
Contributor

himdel commented Oct 27, 2020

👍 Looks like this was react-dropzone/react-dropzone#1022 and they resolved it in a new react-dropzone release (= react-dropzone 11.2.1 + file-selector 0.2.2).

=> #1147

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants