Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cops to use updated names #387

Closed
wants to merge 1 commit into from
Closed

Rename cops to use updated names #387

wants to merge 1 commit into from

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Dec 4, 2019 •
edited

Fixes this thing:

Error: The `Layout/AlignHash` cop has been renamed to `Layout/HashAlignment`.
(obsolete configuration found in .rubocop-https---raw-githubusercontent-com-ManageIQ-guides-master--rubocop-base-yml, please update it)
The `Naming/UncommunicativeMethodParamName` cop has been renamed to `Naming/MethodParameterName`.
(obsolete configuration found in .rubocop-https---raw-githubusercontent-com-ManageIQ-guides-master--rubocop-base-yml, please update it)

see rubocop/rubocop#7077 (comment)

kbrock
kbrock approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error too

@Fryguy
Copy link
Member

Fryguy commented Dec 9, 2019

If you change it here, you have to update the bot as well to bump the minimum version of rubocop, otherwise the bot will fail

@Fryguy
Copy link
Member

Fryguy commented Dec 9, 2019

cc @bdunne

@bdunne
Copy link
Member

bdunne commented Dec 10, 2019

What version requires this change?

@d-m-u
Copy link
Contributor Author

d-m-u commented Dec 10, 2019

.77 includes some name standardization stuff.

d-m-u added a commit to d-m-u/miq_bot that referenced this pull request Jan 30, 2020
@d-m-u
Bump rubocop to 0.77
7173c9c 
ManageIQ/guides#387 (comment)
@d-m-u d-m-u mentioned this pull request Jan 30, 2020
Closed
d-m-u added a commit to d-m-u/miq_bot that referenced this pull request Jan 31, 2020
@d-m-u
Bump rubocop to 0.77
dbf225d 
ManageIQ/guides#387 (comment)
d-m-u added a commit to d-m-u/miq_bot that referenced this pull request Feb 22, 2020
@d-m-u
Bump rubocop to 0.77
5d42365 
ManageIQ/guides#387 (comment)
@kbrock
Copy link
Member

kbrock commented Feb 24, 2020

we nailed down the version of the cop gem.
Do we still need these changes?

@d-m-u d-m-u closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrock kbrock kbrock approved these changes

Assignees
No one assigned
Labels
needs bot rubocop upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-m-u @Fryguy @bdunne @kbrock