Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_local_notifications] Rename Converters - conflict with another libraries #2175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[flutter_local_notifications] Rename Converters - conflict with another libraries #2175

wants to merge 1 commit into from

Conversation

MarkerwApk
Copy link

@MarkerwApk MarkerwApk commented Dec 4, 2023 •
edited

Fix: #2160

@MarkerwApk MarkerwApk mentioned this pull request Dec 4, 2023
Open
MaikuB
MaikuB reviewed Dec 27, 2023
View reviewed changes
flutter_local_notifications/darwin/Classes/NotificationParser.h
@@ -8,7 +8,7 @@

NS_ASSUME_NONNULL_BEGIN

@interface Converters : NSObject
@interface NotificationParser : NSObject
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Rather than renaming from Converters to NotificationParser, would you be able to add the FLN prefix (an abbreviation of flutter local notifications) so that it's FLNConverters instead? Idea came about seeing the official plugins use FLT (presumably for Flutter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaikuB MaikuB MaikuB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Conflict with OpenCV
2 participants
@MarkerwApk @MaikuB