Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete, unsafe Py_TRASHCAN_SAFE_BEGIN/END #1150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

musicinmybrain
Copy link
Contributor

Use Py_TRASHCAN_BEGIN/END instead.

https://bugs.python.org/issue44874

These are removed from the limited C API in Python 3.9, deprecated in 3.11, and removed in Python 3.13:

https://docs.python.org/3.13/whatsnew/3.13.html#id8

@musicinmybrain
Copy link
Contributor Author

When combined with #1101, this allows me to build the python-asyncpg Fedora package for Python 3.13, although I do see two test failures on Python 3.13:

=========================== short test summary info ============================
FAILED tests/test_connect.py::TestClientSSLConnection::test_ssl_connection_client_auth_custom_context
FAILED tests/test_connect.py::TestClientSSLConnection::test_ssl_connection_client_auth_fails_with_wrong_setup
= 2 failed, 300 passed, 2 skipped, 2 deselected, 2 warnings in 151.11s (0:02:31) =

Both are due to something like:

ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Basic Constraints of CA cert not marked critical (_ssl.c:1020)

I presume this is due to a deficiency of the test certificates in tests/certs/.

Use Py_TRASHCAN_BEGIN/END instead.

https://bugs.python.org/issue44874

These are removed from the limited C API in Python 3.9, deprecated in
3.11, and removed in Python 3.13:

https://docs.python.org/3.13/whatsnew/3.13.html#id8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant