Implement GSSAPI authentication #1122
Conversation
eltoder
force-pushed
the
feature/auth-gss
branch
from
f7bd646
to
8c3e144
Compare
|
@elprans appreciate if you could take a look! |
| if 'krbsrvname' in query: | ||
| val = query.pop('krbsrvname') | ||
| if krbsrvname is None: | ||
| krbsrvname = val |
There was a problem hiding this comment.
Please add handling of the PGKRBSRVNAME environment variable as well to stay compatible with libpq.
| @@ -2235,6 +2236,10 @@ async def connect(dsn=None, *, | |||
| or the value of the ``PGTARGETSESSIONATTRS`` environment variable, | |||
| or ``"any"`` if neither is specified. | |||
|
|
|||
| :param str krbsrvname: | |||
There was a problem hiding this comment.
Mention the new parameter in a .. versionadded:: block below please.
eltoder
force-pushed
the
feature/auth-gss
branch
from
8c3e144
to
073ff14
Compare
|
@elprans I was wondering about testing as well, but did not look very carefully. First, I don't know if the version of postgres used in CI (https://github.com/MagicStack/asyncpg/blob/master/.github/workflows/install-postgres.sh) is even compiled with gssapi support. If not, this will be the first thing to fix. Once this is solved, we can use something like k5test (https://github.com/pythongssapi/k5test) to set up a kerberos environment, start a server and test that auth works. |
Most commonly used with Kerberos. Closes: MagicStack#769
eltoder
force-pushed
the
feature/auth-gss
branch
from
073ff14
to
c19cd56
Compare
|
@elprans I fixed the test. |
eltoder
force-pushed
the
feature/auth-gss
branch
from
c19cd56
to
0b29765
Compare
|
@elprans I added unit tests using k5test. From my testing so far it appears that Ubuntu builds of postgres have kerberos support of out the box, so this is fairly straightforward. There is a good chance this will not work in CI on the first try, so I would appreciate if you could help. |
eltoder
force-pushed
the
feature/auth-gss
branch
2 times, most recently
from
469aab2
to
cfd647a
Compare
|
I think this is good to go. Thanks @eltoder! |
|
@elprans Any chance of a patch release (0.29.1) in the near future? |
Most commonly used with Kerberos.
Closes: #769