Cast js-defined variables to string #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
changed the title
MadLittleMods
requested changes
Sep 16, 2018
test/test.js
Outdated
| 'null-value': null, | ||
| 'undefined-value': undefined, | ||
| 'object-value-passed-by-mistake': {} | ||
| }; |
There was a problem hiding this comment.
We should add a Boolean(true/false)
There was a problem hiding this comment.
Agree, done in shonie@2c651e8f3df1b835aa023375d74a2306c9bfef96
test/test.js
Outdated
| @@ -22,6 +22,14 @@ var MOCK_JS_VARIABLES = { | |||
| 'js-defined-no-prefix': '#ff0000' | |||
| }; | |||
|
|
|||
| var INVALID_JS_VARIABLES = { | |||
There was a problem hiding this comment.
Perhaps rename to NON_STRING_VARIABLES
There was a problem hiding this comment.
Agree too. It is in shonie@2c651e8f3df1b835aa023375d74a2306c9bfef96 too.
Can i squash commits now?
Thank you for review!
PR #84 remarks
MadLittleMods
approved these changes
Sep 26, 2018
MadLittleMods
added a commit
that referenced
this pull request
Sep 26, 2018
|
Published in Thanks @shonie ❤️ |
|
You welcome, @MadLittleMods! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #83
Cast js-defined variables to string