This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
MAINT: rename MacOS arm64 wheels #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* automatically rename MacOS arm64 thin wheel files to use version `12_0` instead of `11_0`; the verbose file move should print out the change for us if successful
tylerjereddy
commented
Nov 23, 2021
| set -xe | ||
| for file in `find ./wheelhouse -type f -name '*11_0_arm64*.whl'`; do mv -v "$file" "${file/11_0_arm64/12_0_arm64}"; done | ||
| displayName: "Rename MacOS arm64 wheels for version 12.0 minimum" | ||
| condition: eq(variables['PLAT'], 'arm64') |
There was a problem hiding this comment.
this is slight overkill since there's only one wheel per matrix entry, but it does seem to work locally and the paradigm was conveniently available from a stackoverflow snippet.. let's see what CI says..
rgommers
reviewed
Nov 23, 2021
|
That's true, though CI is passing and we don't have universal2 wheels on the release branch so maybe we can merge for now and open an issue. |
|
Sure, that's fine with me - in it goes. Thanks Tyler! |
tylerjereddy
added a commit
to tylerjereddy/scipy-wheels
that referenced
this pull request
Nov 23, 2021
* automatically rename MacOS arm64 thin wheel files to use version `12_0` instead of `11_0`; the verbose file move should print out the change for us if successful
|
For future archeologists: this was because of the kernel panic on macOS 11: scipy/scipy#14688 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use version
12_0instead of11_0; the verbose filemove should print out the change for us if successful