Authenticate mails sent by MaMpf (#590)

* Authenticate mails sent by MaMpf

* Fix mails comment

* Add `nil` env fallback due to #542 (this one was removed again in merge commit 4d066c3)

config/environments/production.rb

@@ -71,7 +71,8 @@
   config.action_mailer.smtp_settings = {
     address: ENV.fetch("MAILSERVER"),
     port: 25,
-    domain: ENV.fetch("MAILSERVER")
+    user_name: ENV.fetch("MAMPF_EMAIL_USERNAME"),
+    password: ENV.fetch("MAMPF_EMAIL_PASSWORD")
   }
 
   # Ignore bad email addresses and do not raise email delivery errors.

docker/production/docker.env

@@ -11,7 +11,7 @@ MUESLI_SERVER=https://muesli.mathi.uni-heidelberg.de
 ERDBEERE_API=https://erdbeere.mathi.uni-heidelberg.de/api/v1
 MEMCACHED_SERVER=cache
 
-# Email is send using a mailserver without authentication. Specify how to connect here
+# Email
 FROM_ADDRESS=mampf@mathi.uni-heidelberg.de
 MAILSERVER=mail.mathi.uni-heidelberg.de
 PROJECT_EMAIL=mampf@mathi.uni-heidelberg.de
@@ -22,6 +22,8 @@ IMAPSERVER=mail.mathi.uni-heidelberg.de
 PROJECT_EMAIL_USERNAME=creativeusername
 PROJECT_EMAIL_PASSWORD=secretsecret
 PROJECT_EMAIL_MAILBOX="Other Users/mampf"
+MAMPF_EMAIL_USERNAME=secret
+MAMPF_EMAIL_PASSWORD=secret
 
 # Due to CORS constraints, some urls are proxied to the media server
 DOWNLOAD_LOCATION=https://mampf.mathi.uni-heidelberg.de/mediaforward