Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GraphQL validation error displayed as internal server error #711

Merged
merged 2 commits into from Nov 19, 2020

Conversation

benoitguigal
Copy link
Member

@benoitguigal benoitguigal commented Nov 16, 2020

Implémentation d'un workaround vis à vis d'un bug Apollo qui renvoie un code erreur INTERNAL_SERVER_ERROR lorsque le typage des variables graphQL est erroné.

Tickets Apollo

Exemple

 const BAR = `
  mutation Bar($input: String!){
    bar(input: $input)
  }`
mutate({
  mutation: BAR,
  variables: {toto: "TOTO"} 
})

=> INTERNAL_SERVER_ERROR

D'où le problème remonté sur le forum https://forum.trackdechets.beta.gouv.fr/t/import-dun-bordereau-signe-papier/53/4

  • Mettre à jour la documentation
  • Mettre à jour le change log
  • Documenter les breaking changes dans le change log

@benoitguigal benoitguigal force-pushed the fix/graphql-valiation-error-code branch from 16a0845 to cbe2cdd Compare November 16, 2020 10:28
@benoitguigal benoitguigal requested a review from a team November 16, 2020 13:06
@benoitguigal benoitguigal merged commit b921142 into dev Nov 19, 2020
@benoitguigal benoitguigal deleted the fix/graphql-valiation-error-code branch November 19, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants