Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRA-14056] Cacher liens PDF sur Annexes/Suite si le bordereau est un brouillon #3310

Merged
merged 3 commits into from
May 15, 2024

Conversation

silto
Copy link
Collaborator

@silto silto commented May 9, 2024

Ne pas afficher le lien de téléchargement des PDFs auxquels sont annexés des BSD si ces bordereaux sont en brouillon. Modification faite pour BSDD et BSDA.

  • Unification du fragment Transporter sur BSDD qui était en double et créait un warning Apollo

Demo

Demo.PDF.draft.mov
  • Mettre à jour la documentation
  • Mettre à jour le change log
  • Documenter les manipulations à faire lors de la mise en production (sur le ticket Favro de release)
  • S'assurer que la numérotation des nouvelles migrations est bien cohérente
  • Informer le data engineer de tout changement de schéma DB

Copy link
Collaborator

@GaelFerrand GaelFerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

silto added 2 commits May 15, 2024 01:22
… groupedIn/forwardedIn draft BSDs in details view

+ unify transporter fragment that was present twice and showing an Apollo warning
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@silto silto merged commit 103d20f into dev May 15, 2024
17 checks passed
@silto silto deleted the tra-14056 branch May 15, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants