Skip to content

Commit

Permalink
test_binder.rb - split out test causing issues when run parallel (pum…
Browse files Browse the repository at this point in the history
  • Loading branch information
MSP-Greg committed Apr 2, 2022
1 parent 72807fc commit 161c622
Showing 1 changed file with 21 additions and 19 deletions.
40 changes: 21 additions & 19 deletions test/test_binder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def ssl_context_for_binder(binder = @binder)
end
end

class TestBinder < TestBinderBase
class TestBinderParallel < TestBinderBase
parallelize_me!

def test_synthesize_binds_from_activated_fds_no_sockets
Expand Down Expand Up @@ -275,24 +275,6 @@ def test_env_contains_stderr
assert_equal @events.stderr, env_hash["rack.errors"]
end

def test_ssl_binder_sets_backlog
skip_unless :ssl

host = '127.0.0.1'
port = UniquePort.call
tcp_server = TCPServer.new(host, port)
tcp_server.define_singleton_method(:listen) do |backlog|
Thread.current[:backlog] = backlog
super(backlog)
end

TCPServer.stub(:new, tcp_server) do
@binder.parse ["ssl://#{host}:#{port}?#{ssl_query}&backlog=2048"], @events
end

assert_equal 2048, Thread.current[:backlog]
end

def test_close_calls_close_on_ios
@mocked_ios = [Minitest::Mock.new, Minitest::Mock.new]
@mocked_ios.each { |m| m.expect(:close, true) }
Expand Down Expand Up @@ -472,6 +454,26 @@ def assert_parsing_logs_uri(order = [:unix, :tcp])
end
end

class TestBinderSingle < TestBinderBase
def test_ssl_binder_sets_backlog
skip_unless :ssl

host = '127.0.0.1'
port = UniquePort.call
tcp_server = TCPServer.new(host, port)
tcp_server.define_singleton_method(:listen) do |backlog|
Thread.current[:backlog] = backlog
super(backlog)
end

TCPServer.stub(:new, tcp_server) do
@binder.parse ["ssl://#{host}:#{port}?#{ssl_query}&backlog=2048"], @log_writer
end

assert_equal 2048, Thread.current[:backlog]
end
end

class TestBinderJRuby < TestBinderBase
def test_binder_parses_jruby_ssl_options
skip_unless :ssl
Expand Down

0 comments on commit 161c622

Please sign in to comment.