Hand-crafted WebTransport Web API bindings #129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOZGIII
force-pushed
the
web-high-level-crate
branch
from
b36125e
to
b2f911f
Compare
MOZGIII
changed the title
MOZGIII
force-pushed
the
web-high-level-crate
branch
5 times, most recently
from
2154a5e
to
892748e
Compare
MOZGIII
force-pushed
the
web-high-level-crate
branch
from
892748e
to
0234d14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by: rustwasm/wasm-bindgen#3919
This is a replacement for the
web-syscrate (and #117), hard-written instead of being code-generated to overcome the current shortcomings of thewasm_bindgen_webidlcodegen and its choices.See more on that: rustwasm/wasm-bindgen#3921
Currently requires a custom
wasm_bindgenwith rustwasm/wasm-bindgen#3919 applied.The rationale for the hard-written bindings are greater for the development experience, since you get the code that doesn't have
JsValues as return types - but a much saner types without a need for manual conversion (this is actually something that we had bugs with before), but also performance gains, since we can addfinalclause to thewasm_bindgenmacro invocation for more efficient bindings at the hot I/O paths.The hand crafted bindings turned out to be much more comprehensive and useful than the generated ones - because the generated bindings just lack some huge parts of the API surface, and other part of the API are simply generated wrong and/or unusable due to invalid assumptions of the code generator. Needless to say, the generated code is just not ergonomic without a real reason for it - must be a shortcoming of the generator, and most likely fixable - see rustwasm/wasm-bindgen#3921.