Implement new preprocessData and types to support new React marks #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartikcho
requested changes
Jun 26, 2020
There was a problem hiding this comment.
I didn't check the tests since I'm not very familiar with testing so I'll leave that to @jevakallio , everything else looks good except with some changes left to make.
kartikcho
approved these changes
Jun 26, 2020
taneliang
commented
Jun 29, 2020
| expect( | ||
| // prettier-ignore | ||
| preprocessData([ | ||
| {"args":{"data":{"documentLoaderURL":"https://concurrent-demo.now.sh/","isLoadingMainFrame":true,"navigationId":"43BC238A4FB7548146D3CD739C9C9434"},"frame":"FD65D9AFD04B1295CEA36B883F0FA82F"},"cat":"blink.user_timing","name":"navigationStart","ph":"R","pid":9312,"tid":10252,"ts":8993749139,"tts":1646191}, |
There was a problem hiding this comment.
This array is extremely long and it may be a good idea to put it in a separate JSON file, but I think there's some value in having the data visible when you read the tests, instead of having to poke in another file. Opinions welcome but I think this inlined array is good enough for now.
|
Merging to unblock #24. @jevakallio feel free to comment further if you have anything :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements
preprocessDataV2and add other V2 types, to support the new user timing marks added in MLH-Fellowship/react#11.preprocessDataV2is not being used in app code yet, but tests have been written to ensure that the implementation is mostly correct.Also added new profiles exported from the Chrome performance tab + versions filtered to contain only
blink.user_timingevents.Resolves #13.
Design
preprocessDataV2is largely adapted from Brian's originalpreprocessData. The biggest design change I made was to split the React codebase-style pseudo-class/method structure into completely separate functions. Imo this makes it much easier to trace the code as the inputs and outputs of each function is clear, instead of allowing all "methods" in the pseudo-class to mutate some shared variables.ReactEventV2is now a disjoint union type. Not sure how useful this will be, but for now this allows us to enforce the presence of some fields that only apply to certain React events. I did not changeReactMeasureV2as they all seem to contain the same fields.Would love to know your thoughts.
Rollout plan
Test plan
yarn test