Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update preprocessData code and types to support new profiling marks #13

Closed
3 tasks done
taneliang opened this issue Jun 22, 2020 · 0 comments · Fixed by #20
Closed
3 tasks done

Update preprocessData code and types to support new profiling marks #13

taneliang opened this issue Jun 22, 2020 · 0 comments · Fixed by #20
Assignees
@taneliang
Labels
importance: 1 - must have Must be implemented for the issue's phase to be complete phase: 1 - MVP Tasks that get us to our initial MVP urgency: 1 - within 2 days work type: implementation A task that primarily involves bashing code work type: investigation A task that primarily involves digging into a particular problem
Projects
React Concurrent Mode Profiler

Comments

@taneliang
Copy link
Member

taneliang commented Jun 22, 2020 •
edited

Steps

Acceptance criteria

  • A new ReactProfilerDataV2 and other V2 types should be created to support the new profiling marks.
  • preprocessDataV2 should transform a raw profiling JSON into a correct ReactProfilerDataV2
  • No parsing errors in console on page load
  • Neat code, possibly tested (blocked by Set up testing infrastructure #14)
@taneliang taneliang created this issue from a note in React Concurrent Mode Profiler (To do) Jun 22, 2020
@taneliang taneliang moved this from To do to In progress in React Concurrent Mode Profiler Jun 22, 2020
@taneliang taneliang self-assigned this Jun 22, 2020
@taneliang taneliang mentioned this issue Jun 22, 2020
Merged
@taneliang taneliang moved this from In progress to Review in progress in React Concurrent Mode Profiler Jun 25, 2020
@taneliang taneliang mentioned this issue Jun 25, 2020
Merged
React Concurrent Mode Profiler automation moved this from Review in progress to Done Jun 29, 2020
@taneliang taneliang added importance: 1 - must have Must be implemented for the issue's phase to be complete phase: 1 - MVP Tasks that get us to our initial MVP urgency: 1 - within 2 days work type: implementation A task that primarily involves bashing code work type: investigation A task that primarily involves digging into a particular problem labels Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taneliang taneliang

Labels
importance: 1 - must have Must be implemented for the issue's phase to be complete phase: 1 - MVP Tasks that get us to our initial MVP urgency: 1 - within 2 days work type: implementation A task that primarily involves bashing code work type: investigation A task that primarily involves digging into a particular problem
Projects
No open projects
React Concurrent Mode Profiler
  
Done
Milestone
No milestone
1 participant
@taneliang