Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user timing marks for scheduling profiler tool #11
Add user timing marks for scheduling profiler tool #11
Changes from 7 commits
ec17600
3e5f821
ed384aa
c5c6bd4
054781d
5fb8525
eec07b7
560c396
414866d
791dae7
63580cd
30d5f7e
68d6430
7ce6931
418d02a
4f6846a
d3d0459
4101fd7
9f64b78
36e79f4
1628476
660559d
501c4b9
b716ad0
06b038d
c014d6e
8fd53ea
142d5c1
3c477c4
1b12ee5
f42b0a0
6a23d18
1c5997e
8e529f4
4b51d6d
c104dc0
ca75690
d2c090e
b766b17
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jevakallio Would also appreciate if you could see if this new condition makes sense.
This code marks when a render is cancelled, and the condition replaces an expiration date-based one. I'm not too confident of my understanding of both lanes and expiration times, so this is the best I could come up with.
The marks look like they're in the correct position at least, and I don't see them in unexpected places either.
Update: the screenshots below are outdated: our bitmask is now transmitted in decimal (e.g.
--render-start-512
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will detect an interruption, but it will also have false positives.
I believe a way to make it have fewer false positives would be to check that there are actually WIP lanes, e.g.
But I think this will also still have false positives during hydration. I'm actually not sure of what to do here. Maybe we should just leave this as a "TODO" entirely and we can discuss it with Andrew on the final PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch. Checking for WIP lanes makes sense.
I know this doesn't really affect our profiler tool, but I'd love to understand the lanes architecture better: why would there be false positives during hydration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, I think we should remove this entirely for now. Even with the wip lanes check, I think this would report renders are being "abandoned" when they weren't. Like I said, I'm actually not sure of what to do here 😄 let's talk more about it on the final PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 Yeah sounds good. I've removed markRenderAbandoned and this call in 4101fd7, and we can revert it if we figure out a way to do this. Thank you!