Remove poetry.lock file #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx1111
changed the title
|
Fun, running into more issues when importing wfdb/pandas: |
cx1111
changed the title
tompollard
approved these changes
May 2, 2022
| - Documentation is provided. New functions and classes should have numpy/scipy style [docstrings](https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt). | ||
| - Unit tests are written for new features that are not covered by [existing tests](https://github.com/MIT-LCP/wfdb-python/tree/master/tests). | ||
| - The code style is consistent with the project's formating standards. |
There was a problem hiding this comment.
Typo in "formatting" and seems unrelated to PR topic but that's okay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scipy version in lock to 1.7.3: This should help to streamline development a bit more, since many of us main contributors are using M1 macs. I would like to be able to install the dependency versions in the lock file with a simplepoetry install. scipy/scipy#13409Remove
poetry.lockfile. https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-controlIt seems like the lock file isn't always suitable for library developers using multiple platforms, and is more useful for a deployed application on a consistent platform which requires exact pinned dependencies.