Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] first draft of PDBx Reader #4303

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

[WIP] first draft of PDBx Reader #4303

wants to merge 7 commits into from

Conversation

richardjgowers
Copy link
Member

@richardjgowers richardjgowers commented Sep 29, 2023

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4303.org.readthedocs.build/en/4303/

@richardjgowers richardjgowers changed the title first draft of PDBx Reader [WIP] first draft of PDBx Reader Sep 29, 2023
@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Linter Bot Results:

Hi @richardjgowers! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ✅ Passed

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/6429099481/job/17457515242


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (427f1a7) 93.40% compared to head (837b861) 93.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4303      +/-   ##
===========================================
- Coverage    93.40%   93.15%   -0.26%     
===========================================
  Files          170      186      +16     
  Lines        22257    23429    +1172     
  Branches      4071     4079       +8     
===========================================
+ Hits         20790    21825    +1035     
- Misses         951     1088     +137     
  Partials       516      516              
Files Coverage Δ
package/MDAnalysis/coordinates/PDBx.py 0.00% <0.00%> (ø)
package/MDAnalysis/topology/PDBxParser.py 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 28:80: E501 line too long (98 > 79 characters)
Line 29:80: E501 line too long (113 > 79 characters)
Line 62:80: E501 line too long (80 > 79 characters)

@hmacdope hmacdope modified the milestone: Release 3.0 Oct 7, 2023
@orbeckst orbeckst added the hackathon part of a MDAnalysis coding event label Oct 10, 2023
@orbeckst
Copy link
Member

Do you want reviews on this, @richardjgowers ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants