Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust's aliasing model disallows creating exclusive
&mut
references from shared&
references, except through anUnsafeCell
. Therefore, I modifiedDesync
andUnsafeJob
to no longer do that. (Note that*mut
pointers are the fundamental type for shared mutable access.) Also, theBox
inDesync
can't exist alongside the&mut
references created in the jobs, so I madeaction
store the pointer resulting fromBox::into_raw()
; thedrop()
function similarly callsBox::from_raw()
. Finally, sinceDesync
is an interior mutability type with no poisoning, I used aPhantomData
to mark it as!RefUnwindSafe
, since it can leak data across acatch_unwind
boundary with a shared reference.This is a breaking change. It fixes #6.