Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin flake8 version #160

Merged
merged 1 commit into from Dec 28, 2022
Merged

pin flake8 version #160

merged 1 commit into from Dec 28, 2022

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 28, 2022

Description

flake8 v6.0.0 removed support for type comments which are required for Python 2.7 type hints. This is a temporary fix to allow workflows to continue working until an alternate solution is found.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

flake8 v6.0.0 removed support for type comments which are required for Python 2.7 type hints. This is a temporary fix to allow workflows to continue working until an alternate solution is found.
@ReenigneArcher ReenigneArcher merged commit f39204d into nightly Dec 28, 2022
@ReenigneArcher ReenigneArcher deleted the fix/pin-flake8-version branch December 28, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant