Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to specify the python and flake8 version based on the project #131

Open
ReenigneArcher opened this issue Nov 29, 2022 · 2 comments
Open
Assignees

Comments

@ReenigneArcher
Copy link
Member

ReenigneArcher commented Nov 29, 2022

python-version: '3.10'

Since flake8 v6.0.0, some valid python syntax is flagged which causes workflows to fail. Specifically type hints comments, which are valid in all current versions of python according to PEP 0484. This is all thanks to this pull in pyflakes, PyCQA/pyflakes#684

Unfortunately several of our projects require support of Python 2.7 so cannot just switch to new type hint annotations. Seems like a hasty and poorly thought out decision to completely drop support for something that is valid and acceptable syntax.

Perhaps some better options:

@ReenigneArcher
Copy link
Member Author

The solutions here, (https://unterwaditzer.net/2019/mypy-and-python2.html), may also work for flake8.

@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Dec 6, 2022

@ReenigneArcher ReenigneArcher mentioned this issue Dec 28, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants