Improve Code Quality in a few places #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This forbids using any APIs that are incompatible with the MSRV. The MSRV is also specified in all the `Cargo.toml` files now. - The `unicase` crate is removed. The standard library can mostly handle it just fine. - The `Instant` type of the `time` crate is deprecated. You are supposed to use extension methods on the standard library's `Instant` type. This is what we do, though we still wrap the type to make it behave still mostly the same. - Fixes a bug with gradient backgrounds in the web renderer.
CryZe
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.tomlfiles now.unicasecrate is removed. The standard library can mostly handle it just fine.Instanttype of thetimecrate is deprecated. You are supposed to use extension methods on the standard library'sInstanttype. This is what we do, though we still wrap the type to make it behave still mostly the same.