Improve Layer Separations #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
added
enhancement
This improves the code that splits the rendered entities into the bottom and top layers. The top layer is intended to be used for entities that update frequently. This was mostly done pretty well before, but with the web renderer it has been quite easy to find cases that could be improved: 1. The graph used to always be rendered onto the top layer. This does not need to be the case when the timer is paused or just not running at all. 2. Game Time can change all the time, even if the timer is paused. So this is taken into account everywhere now. 3. Columns didn't consider pausing at all either. 4. There was a bug in the web renderer where a brightness of 0 was considered as the default for brightness and thus no brightness change was applied. This should've been at 1. 5. The new Rust release brought some new clippy lints around string buffer reusage that were addressed.
CryZe
force-pushed
the
improve-layer-separations
branch
from
70fb0d0
to
2824f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the code that splits the rendered entities into the bottom and top layers. The top layer is intended to be used for entities that update frequently. This was mostly done pretty well before, but with the web renderer it has been quite easy to find cases that could be improved: