Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run parser: deserialize the AutoSplitterSettings #797

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Run parser: deserialize the AutoSplitterSettings #797

wants to merge 4 commits into from

Conversation

AlexKnauth
Copy link
Contributor

@AlexKnauth AlexKnauth commented Apr 30, 2024 •
edited

Based on the work of @Refragg, I updated it to use the new settings map and settings value types.

  • Make sure the auto-splitter gets the settings from a freshly opened splits file.
  • Make sure a saved splits file gets the settings from the autosplitter, when the autosplitter has edited them.
  • Make sure a saved splits file gets to keep its Legacy XML, when the autosplitter has no settings of its own to replace it with.

@AlexKnauth AlexKnauth marked this pull request as ready for review April 30, 2024 17:23
@AlexKnauth AlexKnauth changed the title WIP: Run parser: deserialize the AutoSplitterSettings Run parser: deserialize the AutoSplitterSettings Apr 30, 2024
@AlexKnauth AlexKnauth force-pushed the Refragg-2 branch 2 times, most recently from 43cfe17 to ba19f96 Compare May 11, 2024 16:44
Refragg and others added 4 commits May 28, 2024 17:46
@Refragg @AlexKnauth
Run parser: deserialize the AutoSplitterSettings
3453eae 
This commit implements the deserialization of the AutoSplitterSettings XML section of a LiveSplit splits file.
This can surely use some improvements regarding the compatibility without the auto-splitting feature and some other things.
I think it is good as a first step though and we can keep iterating on it.
@AlexKnauth
settings map translation
ac1375a
@AlexKnauth
reload
1e9d00d
@AlexKnauth
trait TimerAutoSplitterSettings
f606be3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexKnauth @Refragg