Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detox failure on jenkins #2078

Open
wants to merge 25 commits into
base: release/3.0.1
Choose a base branch
from

Conversation

abhishekjalan87
Copy link
Contributor

@abhishekjalan87 abhishekjalan87 commented Oct 11, 2023

What was the problem?

Jekins unnable to open Simulator, resolves #1999

How was it solved?

added one line to boot the simulator "xcrun simctl boot"

How was it tested?

Tested locally on a Jenkins node and also using Jenkins pipeline.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023

CLA assistant check
All committers have signed the CLA.

@abhishekjalan87 abhishekjalan87 changed the base branch from 1999-fix-detox-failure-on-jenkins to release/3.0.0 October 11, 2023 14:37
Jenkinsfile Outdated
# Install Command Line Tools
cp env.test.json env.json
npx react-native start &
xcrun simctl shutdown F084BDF1-55E5-4E4C-B4D6-70AA1DA5D41F
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abhishekjalan87, it seems we still have an error here, we might need to run this command without necessarily throwing the error if the device is already shut down
Screenshot 2023-10-20 at 13 36 00

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed this issue, now it will not throw any more error if simulator is already in shutdown state.

@@ -0,0 +1,33 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might not need this file either, I created this cause I updated my system to latest and has iPhone 15, but @ClementeSerrano and most likely Jenkins might not have this device. So, this script is to ensure it picks the first device from the system to use. Let me know your thoughts pls.

Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

@ManuGowda ManuGowda changed the base branch from release/3.0.0 to development November 27, 2023 20:59
@ManuGowda ManuGowda changed the title 1999 fix detox failure on jenkins fix Fix detox failure on jenkins fix Nov 29, 2023
@ManuGowda ManuGowda changed the title Fix detox failure on jenkins fix Fix detox failure on jenkins Nov 29, 2023
@Balanced02 Balanced02 changed the base branch from development to release/3.0.1 November 29, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Detox failure on Jenkins
4 participants