Add PHPUnit 9 support #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d memory for this case.
|
@steve-todorov Thanks for your PR! I fixed the issue with CI not being hooked to PRs. There seems to be an issue with PHP 7.2 builds. Since apparently PHPUnit dropped support for PHP <= 7.2, I'll fix the expected versions in our TravisCI config file. |
jakubhomoly
approved these changes
Aug 10, 2020
|
I'm ready to merge this, unless you have any concerns @hrcc ? |
|
Thanks for fixing the build! I haven't updated the |
rudowastaken
approved these changes
Aug 10, 2020
|
Looks good, thanks @steve-todorov! |
|
Awesome! Thanks for releasing! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #21 and adds support for PHPUnit 9.
A few key notes:
ResultPrinteris now an interface andDefaultResultPrintershould be extended instead. (Make PHPUnit\TextUI\ResultPrinter an interface sebastianbergmann/phpunit#4024)phpunitto 9 and fixed a few warnings.