Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPUnit 9 support #21

Closed
steve-todorov opened this issue Aug 7, 2020 · 2 comments · Fixed by #22
Closed

Add PHPUnit 9 support #21

steve-todorov opened this issue Aug 7, 2020 · 2 comments · Fixed by #22

Comments

@steve-todorov
Copy link
Contributor

Hi there,

I'm using this dependency and was wondering if there are plans for PHPUnit 9 support?
It looks like in PHPUnit 9 the PHPUnit\TextUI\ResultPrinter class has been converted into an interface (check sebastianbergmann/phpunit#4024) and there is now a PHPUnit\TextUI\DefaultResultPrinter

So the fix to the issue would be simply to change this part:

namespace LimeDeck\Testing;
use PHPUnit\Framework\Test;
use PHPUnit\Framework\Warning;
use PHPUnit\TextUI\ResultPrinter;
use PHPUnit\Util\Test as UtilTest;
use PHPUnit\Framework\AssertionFailedError;
class Printer extends ResultPrinter

to this:

namespace LimeDeck\Testing;

use PHPUnit\Framework\Test;
use PHPUnit\Framework\Warning;
use PHPUnit\TextUI\DefaultResultPrinter;
use PHPUnit\Util\Test as UtilTest;
use PHPUnit\Framework\AssertionFailedError;

class Printer extends DefaultResultPrinter
{
...
}
@jakubhomoly
Copy link
Collaborator

jakubhomoly commented Aug 7, 2020

Hey @steve-todorov, thanks for reporting. Since you've already got this figured out, could you please create a PR? We could release a major version of this to be able to support PHPUnit 9.

Thank you!

@steve-todorov
Copy link
Contributor Author

I've just pushed my changes. Tests are passing on my end but it looks like there's no CI hooked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants