Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Protobuf version fix to allow installing new Lightning #2

Merged
merged 1 commit into from Sep 29, 2022

Conversation

dmitsf
Copy link
Member

@dmitsf dmitsf commented Sep 29, 2022

What does this PR do?

Fixes protobuf contradiction with Lightning.
What we have now:

=> due to this protobuf versions contradiction and due to we don鈥檛 restrict Lightning version in apps requirements (we'd get an error), pip installs very old Lightning version: lightning==2022.7.18 and lightning-app==0.5.7.

For Lightning main repo, the problem was addressed here: Lightning-AI/pytorch-lightning#13259.

Does your PR introduce any breaking changes? If yes, please list them.

No, this is just a fix.

Before submitting

  • Was this discussed/approved via a GitHub issue or with the team? (not for typos and docs)
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally?
  • Did you test your PR on cloud?

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read
the review guidelines. In short, see the
following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels to the PR so it can be classified

Did you have fun?

That was a great python dependencies puzzle! 馃槃

@dmitsf dmitsf merged commit f2b7c5f into main Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants