Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix tex formulas rendering for tutorials #317

Open
wants to merge 2 commits into
base: publication
Choose a base branch
from

Conversation

fnhirwa
Copy link

@fnhirwa fnhirwa commented Mar 20, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This branch is the one that is pinned for docs.
We will need to update the submodule once this is merged into this branch

related to Lightning-AI/pytorch-lightning#19633
The PR at the main branch which was failing to build:
#316

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@github-actions github-actions bot added documentation Improvements or additions to documentation ci/cd labels Mar 20, 2024
@mergify mergify bot requested a review from Borda March 20, 2024 17:30
@fnhirwa fnhirwa marked this pull request as ready for review March 20, 2024 17:31
Copy link

Check out this pull request on聽 ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fnhirwa fnhirwa marked this pull request as draft March 21, 2024 03:53
@Borda
Copy link
Member

Borda commented Mar 22, 2024

Btw, if this PR is different than #316 please name it to match what it does =)

@fnhirwa fnhirwa changed the title docs: added mathjax for rendering tex format as imgmath needs latex engine to run docs: fix tex formulas rendering for tutorials Mar 22, 2024
@fnhirwa fnhirwa marked this pull request as ready for review March 22, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants