Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx conf warning fix #175

Merged
merged 4 commits into from Jun 13, 2022
Merged

Conversation

speediedan
Copy link
Contributor

@speediedan speediedan commented Jun 10, 2022

Before submitting

Closes #178

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #174
Explicitly reference language = "en" to avoid new warning.

Note build-docs check will not pass until #176 is merged. CI testing/nbval check won't pass until #178 is merged.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #175 (36aef23) into main (3fda6eb) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #175   +/-   ##
===================================
  Coverage    75%    75%           
===================================
  Files         2      2           
  Lines       370    370           
===================================
  Hits        276    276           
  Misses       94     94           

@Borda Borda added the bug / fix Something isn't working label Jun 13, 2022
@Borda
Copy link
Member

Borda commented Jun 13, 2022

seem that there is a dead-lock with #178 as that one can't pass CI for missing lang, and this can not build for broken ffmpeg

@Borda Borda enabled auto-merge (squash) June 13, 2022 13:33
@Borda Borda merged commit aa39ef1 into Lightning-AI:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

language = None Warning in Sphinx
2 participants