Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: lock requirements & unfreeze #159

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

CI: lock requirements & unfreeze #159

wants to merge 3 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 15, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

the original work taken from logic for lock requirements

  • setting upper bound for the latest version with locked ones
  • in the CI we augment all requirements files by adding max version

To prepare the latest lock, run:

python .actions/assistant.py create_locked_versions

This can be also automated, to run this generation nightly, and if there is a diff, send a slack msg or create a PR

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the enhancement New feature or request label Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #159 (f869dda) into main (7e3565d) will decrease coverage by 2%.
The diff coverage is 31%.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #159   +/-   ##
===================================
- Coverage    73%    72%   -2%     
===================================
  Files         2      2           
  Lines       382    398   +16     
===================================
+ Hits        280    285    +5     
- Misses      102    113   +11     

@Borda Borda changed the title CI: freeze requirements CI: lock requirements & unfreeze Apr 15, 2022
@stale stale bot added the won't fix This will not be worked on label Jun 23, 2022
@Borda Borda added this to In progress in Improve CI/CD via automation Jun 29, 2022
@Lightning-AI Lightning-AI deleted a comment from stale bot Jun 29, 2022
@stale stale bot removed the won't fix This will not be worked on label Jun 29, 2022
@Borda Borda self-assigned this Aug 15, 2022
@Borda Borda mentioned this pull request Jan 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Improve CI/CD
In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant