Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: reinstall torch versions #155

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CI: reinstall torch versions #155

wants to merge 1 commit into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 10, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

In case some notebook request a specific torchvision or torchtext version all related packages shall be updated
So if torchvision is updated (it hall automatically reinstall torch) but then also torchtext shall be updated

  1. check if any of these packages were changed
  2. if so check mapping table and adjust remaining packages

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the bug / fix Something isn't working label Apr 10, 2022
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #155 (2335659) into main (c257c46) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #155   +/-   ##
===================================
  Coverage    75%    75%           
===================================
  Files         2      2           
  Lines       355    355           
===================================
  Hits        267    267           
  Misses       88     88           

@Borda
Copy link
Member Author

Borda commented May 17, 2022

based on the discussion in #172 these adjustments need to be projected to the pip installation command in the notebook top section as this collision may also happen while running in Colab which already has some pre-instaled versions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant