Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pre-commit config to address black issue #2966 fixed in 22.3.0 #148

Closed

Conversation

speediedan
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

An issue with black (introduced by click) was causing the pre-commit "Format Code" hook to fail. Version 22.3.0 of black was released and needs to be specified with the relevant pre-commit hook we're using.

Fixes #147

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #148 (5f637f0) into main (0b955b5) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #148   +/-   ##
===================================
  Coverage    75%    75%           
===================================
  Files         2      2           
  Lines       353    353           
===================================
  Hits        265    265           
  Misses       88     88           

@Borda Borda added the enhancement New feature or request label Mar 30, 2022
@rohitgr7
Copy link
Contributor

rohitgr7 commented Apr 7, 2022

this is fixed in #153. Sorry I didn't see that there is an already opened PR.

@rohitgr7 rohitgr7 closed this Apr 7, 2022
@speediedan
Copy link
Contributor Author

this is fixed in #153. Sorry I didn't see that there is an already opened PR.

No worries Rohit, it happens. Thanks for all your work. Looking forward to working with you on tutorials in the future.

@speediedan speediedan deleted the fix_pre-commit_config branch May 12, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-commit failing due to black issue (#2966)
7 participants